[1.x] Improve PHP 8.5+ support by avoiding deprecated method calls in tests - #185
Merged
Merged
Conversation
In PHP8.1 ReflectionProperty::setAccessible was made a no-op through https://wiki.php.net/rfc/make-reflection-setaccessible-no-op in PHP8.5 it is now throwing a deprecation warning by: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_reflectionsetaccessible
WyriHaximus
changed the title
Member
Author
|
Had to kick the build a few times as GitHub and possibly the Internet (due to CloudFlare) is glitchy tonight. |
clue
reviewed
Nov 18, 2025
clue
changed the title
WyriHaximus
force-pushed
the
1.x-PHP8.5
branch
from
November 18, 2025 22:43
9290870 to
ab33788
Compare
While I couldn't pin it to the exact commit/PR/NEWS/UPGRADING item, PHP8.5 has seen a number of improvements to streams to make them less buggy. As a result, this test, which already confirmed the expected behavior is now failing because an error is tossed.
WyriHaximus
force-pushed
the
1.x-PHP8.5
branch
from
November 18, 2025 22:44
ab33788 to
e139356
Compare
clue
approved these changes
Oct 3, 2026
clue
left a comment
clue
left a comment
Member
There was a problem hiding this comment.
@WyriHaximus Thanks for the update, changes LGTM! 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for PHP8.5 by running against PHP8.5 on CI and ensuring the code is compatible with PHP8.5.
Builds on #179, #184, and many others.